Add fullwidth page option #3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11e9f10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
To prevent unnecessary layout shift when resizing the window smaller
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
SamyPesse
reviewed
Jul 3, 2025
SamyPesse
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Approving, but I'm concerned that the logic is twisted with different behaviour based on a set of block types.
@BrettJephson how is it done in the editor? any idea on how to make this better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the page-width option is available, we can remove the hardcoded ID and get GBO ready to use the customization option. Also makes some tiny tweaks to make the full-width option work better with different blocks and the page's loading skeleton.